Skip to content

Conversation

@jerqi
Copy link
Contributor

@jerqi jerqi commented Jul 2, 2022

What changes were proposed in this pull request?

Add issue template

Why are the changes needed?

Provide some issue templates for users

Does this PR introduce any user-facing change?

No.

How was this patch tested?

No need.

@jerqi
Copy link
Contributor Author

jerqi commented Jul 2, 2022

Our repo don't have discussions tab. Should we let users to discuss user questions with issues?

@jerqi jerqi added this to the ASF Podling milestone Jul 2, 2022
@jerryshao
Copy link
Contributor

Our repo don't have discussions tab. Should we let users to discuss user questions with issues?

This should be opened by repo maintainer (Apache Infra), I can create a request if we need this.

@jerqi jerqi marked this pull request as draft July 4, 2022 03:51
@jerqi jerqi force-pushed the issue_template branch from 0151219 to 106a0a6 Compare July 4, 2022 04:00
@jerqi jerqi force-pushed the issue_template branch from 106a0a6 to 9f3cc0a Compare July 4, 2022 09:00
@jerryshao
Copy link
Contributor

@jerqi can we please continue this PR, is there any further thing should be addressed in this PR?

@jerryshao jerryshao marked this pull request as ready for review September 26, 2022 03:47
@jerryshao
Copy link
Contributor

close and reopen to trigger the UT again.

@jerryshao jerryshao closed this Sep 26, 2022
@jerryshao jerryshao reopened this Sep 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@cdc8cb6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master       #8   +/-   ##
=========================================
  Coverage          ?   59.14%           
  Complexity        ?     1332           
=========================================
  Files             ?      160           
  Lines             ?     8740           
  Branches          ?      821           
=========================================
  Hits              ?     5169           
  Misses            ?     3305           
  Partials          ?      266           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi
Copy link
Contributor Author

jerqi commented Sep 26, 2022

@jerqi can we please continue this PR, is there any further thing should be addressed in this PR?

I have checked this pr. There is no other things which should be addressed. Let's merge this pr.

@jerqi jerqi merged commit 75921f1 into apache:master Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants