[#669] improvement: refresh application when reading memory data #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #741 +/- ##
============================================
+ Coverage 60.67% 62.81% +2.13%
Complexity 1895 1895
============================================
Files 238 224 -14
Lines 12999 11036 -1963
Branches 1090 1090
============================================
- Hits 7887 6932 -955
+ Misses 4676 3728 -948
+ Partials 436 376 -60
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This reverts commit 8dd3bb7.
jerqi
approved these changes
Mar 19, 2023
Contributor
jerqi
left a comment
jerqi
left a comment
There was a problem hiding this comment.
LGTM, merged to Master & 0.7
jerqi
pushed a commit
that referenced
this pull request
Mar 19, 2023
### What changes were proposed in this pull request? Refresh application when reading memory data. ### Why are the changes needed? In the current logic, application will not be refreshed when reading memory data. In this case, If timeout occurs when spark driver sends heartbeat to shuffle server, the application will be expired. Fix: #669 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need,
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
apache#741) ### What changes were proposed in this pull request? Refresh application when reading memory data. ### Why are the changes needed? In the current logic, application will not be refreshed when reading memory data. In this case, If timeout occurs when spark driver sends heartbeat to shuffle server, the application will be expired. Fix: apache#669 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need,
xianjingfeng
added a commit
to xianjingfeng/uniffle
that referenced
this pull request
Apr 5, 2023
apache#741) ### What changes were proposed in this pull request? Refresh application when reading memory data. ### Why are the changes needed? In the current logic, application will not be refreshed when reading memory data. In this case, If timeout occurs when spark driver sends heartbeat to shuffle server, the application will be expired. Fix: apache#669 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? No need,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refresh application when reading memory data.
Why are the changes needed?
In the current logic, application will not be refreshed when reading memory data. In this case, If timeout occurs when spark driver sends heartbeat to shuffle server, the application will be expired.
Fix: #669
Does this PR introduce any user-facing change?
No.
How was this patch tested?
No need,