Skip to content

[MINOR] fix(test): Fix flaky test for CoordinatorReconfigureNodeMaxTest#testReconfigureNodeMax #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[MINOR] fix(test): Fix flaky test for CoordinatorReconfigureNodeMaxTest#testReconfigureNodeMax #2325

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efd894d
Fix flaky test for CoordinatorReconfigureNodeMaxTest#testReconfigureN…
maobaolong Jan 5, 2025
39ee790
Add comment
maobaolong Jan 8, 2025
37759d3
try to reduce wait time
maobaolong Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...-test/common/src/test/java/org/apache/uniffle/test/CoordinatorReconfigureNodeMaxTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,11 @@ public void testReconfigureNodeMax() throws Exception {
assertEquals(5, info.getServerToPartitionRanges().keySet().size());

// case3: recover its value to 10
Thread.sleep(1000L);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should Awaitility.await.

Copy link
Member Author

@maobaolong maobaolong Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerqi I added a new comment above this line. This sleep to make sure the last modification time of the tempConfFilePath file changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wait for a modification timestamp instead sleep.

try (FileWriter fileWriter = new FileWriter(tempConfFilePath)) {
fileWriter.append(CoordinatorConf.COORDINATOR_SHUFFLE_NODES_MAX.key() + " " + 10);
}
Thread.sleep(1000L);
Awaitility.await().timeout(2, TimeUnit.SECONDS).until(() -> nodeMax.get() == 10);
info = shuffleWriteClient.getShuffleAssignments("app1", 0, 10, 1, TAGS, SERVER_NUM + 10, -1);
assertEquals(10, info.getServerToPartitionRanges().keySet().size());
Expand Down
Loading