[#2282][FOLLOWUP] test: Add UT for DelegationRssShuffleManager#getReader #2287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 2 927 files 2 927 suites 6h 12m 45s ⏱️ Results for commit 4c39534. |
|
The failed test caused by there is no specific |
You should use reflection to solve the similar issue. |
|
@jerqi Sorry I have no idea to solve this mock api through reflection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add UT for DelegationRssShuffleManager#getReader
Why are the changes needed?
Fix: #2282
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New UT