Skip to content

Conversation

@rickyma
Copy link
Contributor

@rickyma rickyma commented Feb 12, 2024

What changes were proposed in this pull request?

Upgrade Netty and GRPC

Why are the changes needed?

A sub PR for: #1519

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (576a925) 54.27% compared to head (1e32dcf) 55.19%.
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1520      +/-   ##
============================================
+ Coverage     54.27%   55.19%   +0.91%     
- Complexity     2807     2808       +1     
============================================
  Files           427      410      -17     
  Lines         24349    22049    -2300     
  Branches       2077     2082       +5     
============================================
- Hits          13215    12169    -1046     
+ Misses        10305     9121    -1184     
+ Partials        829      759      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Test Results

2 287 files  ±0  2 287 suites  ±0   4h 28m 30s ⏱️ +45s
  819 tests ±0    818 ✅ ±0   1 💤 ±0  0 ❌ ±0 
9 086 runs  ±0  9 073 ✅ ±0  13 💤 ±0  0 ❌ ±0 

Results for commit 1e32dcf. ± Comparison against base commit 866f5ff.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rickyma , merged to master.

@jerqi jerqi merged commit d87dc90 into apache:master Feb 13, 2024
@rickyma rickyma mentioned this pull request Feb 13, 2024
3 tasks
@rickyma rickyma deleted the issue-1472-part-1 branch May 5, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants