[#1466] feat(server): introduce the JvmPauseMonitor to detect the gc pause #1470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1470 +/- ##
============================================
+ Coverage 54.12% 54.91% +0.79%
Complexity 2773 2773
============================================
Files 423 404 -19
Lines 24215 21939 -2276
Branches 2062 2071 +9
============================================
- Hits 13106 12048 -1058
+ Misses 10296 9148 -1148
+ Partials 813 743 -70 ☔ View full report in Codecov by Sentry. |
Contributor
|
Why do we need this after we already have JVM metrics? |
Member
Author
Sometimes the metric system is not enabled. BTW this class is referred from Hadoop https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java |
jerqi
approved these changes
Jan 18, 2024
zuston
added a commit
to zuston/incubator-uniffle
that referenced
this pull request
Mar 19, 2024
…he gc pause (apache#1470) ### What changes were proposed in this pull request? Introduce the JvmPauseMonitor to detect the gc pause ### Why are the changes needed? Fix: apache#1466 We have some loop check logic in shuffle-server, sometimes the GC pause will make some pre-allocated buffer removed. If we have this monitor, we will find out this reason rather than guess. Although the JVM metrics are also valid. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
introduce the JvmPauseMonitor to detect the gc pause
Why are the changes needed?
Fix: #1466
We have some loop check logic in shuffle-server, sometimes the GC pause will make some pre-allocated buffer removed.
If we have this monitor, we will find out this reason rather than guess. Although the JVM metrics are also valid.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests