Skip to content

check overflow on getting field id #3075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

check overflow on getting field id #3075

wants to merge 1 commit into from

Conversation

jp0317
Copy link

@jp0317 jp0317 commented Dec 12, 2024

Add overflow checking when getting field id based on field delta.

@fishy fishy added the rust label Dec 12, 2024
@Jens-G
Copy link
Member

Jens-G commented Feb 28, 2025

Sth is not right here

 error: use of `ok_or` followed by a function call

@jp0317
Copy link
Author

jp0317 commented Feb 28, 2025

yeah, it's should be fine to use ok_or there. this seems to be a false alarm (found a similar issue here)

@Jens-G
Copy link
Member

Jens-G commented Mar 1, 2025

Maybe but it breaks the build.

@jimexist
Copy link
Member

ok or else saves one allocation, it's trivial to change to that

@Jens-G
Copy link
Member

Jens-G commented Apr 18, 2025

trivial to change to that

Seems not the case ... or is it? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jp0317 @Jens-G @jimexist @fishy