TEZ-4600: Secret managers in Tez should respect the algorithm set by hadoop #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
abstractdog
force-pushed
the
TEZ-4600
branch
from
0a55dc8 to
bd3ed36
Compare
abstractdog
changed the title
ayushtkn
reviewed
Feb 25, 2025
| } catch (NoSuchAlgorithmException nsa) { | ||
| throw new IllegalArgumentException("Can't find " + algorithm + " algorithm.", nsa); | ||
| } catch (InvalidKeyException ike) { | ||
| throw new IllegalArgumentException("Invalid key to HMAC computation", ike); |
There was a problem hiding this comment.
Do we want to hardcode HMAC over here? InvalidKeyException can be thrown for other algorithms as well, right?
There was a problem hiding this comment.
oh, right, this is a leftover from the default HMAC-era
This comment was marked as outdated.
This comment was marked as outdated.
|
🎊 +1 overall
This message was automatically generated. |
…hadoop Change-Id: I236505c2439ba675f4a277aeb1f7b0faae2d1053
abstractdog
force-pushed
the
TEZ-4600
branch
from
35a7574 to
a060cc4
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
changed hadoop enums to strings until TEZ-4607 |
|
there is a checkstyle warning that has shown up for the unused import, we need to fix it before we merge |
makes sense, I just pushed a commit to remove it |
|
🎊 +1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the JobTokenSecretManager in Tez able to use the algorithm specified in:
An additional comment was needed to upgrade to hadoop 3.5.0-SNAPSHOT to compile against the changes of YARN-11738. This PR can be merged once Tez upgraded its hadoop.version to 3.5.0 (which needs a hadoop release first :) )
testing done: turned on SSL shuffle on a cluster having YARN-11738, DAG failed with exceptions mentioned on jira, then with the fix DAG ran successfully (as ShuffleScheduler + ShuffleManager used the non-default algorithm configured)