-
Notifications
You must be signed in to change notification settings - Fork 113
chore: Move apache.amber to apache.texera.amber
#4094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ra.amber This commit refactors the package structure by moving all Amber engine code from org.apache.amber to org.apache.texera.amber. This aligns the package naming with the Texera project organization. - Moved all source directories preserving git history - Updated package declarations in 576 Scala/Java files - Updated import statements across all files - Updated Python proto imports (57 files) - Updated protobuf packages (14 files) - Updated frontend TypeScript imports (2 files) - Updated configuration files (cluster.conf) - Updated string literals with class references for reflection Closes #4003
356a020 to
ea42805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR performs a large-scale refactoring to migrate the Amber engine codebase from the org.apache.amber package namespace to org.apache.texera.amber. This change aligns the package structure with the Apache Texera project organization and ensures all components are properly namespaced.
Key Changes:
- Migrated all source directories across 8 Scala/Java modules from
org.apache.ambertoorg.apache.texera.amber - Updated package declarations in 576 Scala/Java files
- Updated 57 Python files to use new proto import paths
- Modified 14 Protobuf files with new Java package declarations
- Updated configuration files and string literals containing class names for reflection/dynamic loading
Reviewed changes
Copilot reviewed 293 out of 709 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| cluster.conf | Updated Kryo serializer configuration to reference new package namespace |
| Test files (Scala) | Updated package declarations and imports across all test files |
| Main source files (Scala) | Updated package declarations and imports across engine, architecture, and utility classes |
| Python files | Updated proto imports to reflect new namespace structure |
| WorkerSpec.scala | Updated class name string literal for dynamic loading of DummyOperatorExecutor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chenlica
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What changes were proposed in this PR?
This PR refactors the package structure by moving all Amber engine code from
org.apache.ambertoorg.apache.texera.amber. This aligns the package naming with the Texera project organization and ensures all components are properly namespaced under the Apache Texera organization.Key Changes:
Directory Structure Migration - Moved all source directories:
Code Updates - Updated across 707 files:
Package Namespace Changes:
Any related issues, documentation, discussions?
Closes #4003
How was this PR tested?
CI
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Sonnet 4.5 (Cursor IDE)