Skip to content

Conversation

@Yicong-Huang
Copy link
Contributor

What changes were proposed in this PR?

This PR refactors the package structure by moving all Amber engine code from org.apache.amber to org.apache.texera.amber. This aligns the package naming with the Texera project organization and ensures all components are properly namespaced under the Apache Texera organization.

Key Changes:

  1. Directory Structure Migration - Moved all source directories:

    • Scala/Java sources: 8 modules moved
    • Protobuf definitions: 14 files moved
    • Python proto generated code: moved under new namespace
    • Frontend TypeScript proto: moved under new namespace
  2. Code Updates - Updated across 707 files:

    • Package declarations in 576 Scala/Java files
    • Import statements across all Scala/Java files
    • 57 Python files updated for new proto imports
    • 14 Protobuf files updated with new Java package
    • 2 TypeScript files updated with new import paths
    • Configuration files (cluster.conf)
    • String literals containing class names for reflection/dynamic loading
  3. Package Namespace Changes:

    - org.apache.amber.engine.common
    - org.apache.amber.operator.*
    - org.apache.amber.core.*
    - org.apache.amber.compiler.*
    
    + org.apache.texera.amber.engine.common
    + org.apache.texera.amber.operator.*
    + org.apache.texera.amber.core.*
    + org.apache.texera.amber.compiler.*

Any related issues, documentation, discussions?

Closes #4003

How was this PR tested?

CI

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Sonnet 4.5 (Cursor IDE)

@Yicong-Huang Yicong-Huang self-assigned this Dec 1, 2025
@github-actions github-actions bot added engine python refactor Refactor the code frontend Changes related to the frontend GUI service common labels Dec 1, 2025
…ra.amber

This commit refactors the package structure by moving all Amber engine code
from org.apache.amber to org.apache.texera.amber. This aligns the package
naming with the Texera project organization.

- Moved all source directories preserving git history
- Updated package declarations in 576 Scala/Java files
- Updated import statements across all files
- Updated Python proto imports (57 files)
- Updated protobuf packages (14 files)
- Updated frontend TypeScript imports (2 files)
- Updated configuration files (cluster.conf)
- Updated string literals with class references for reflection

Closes #4003
@Yicong-Huang Yicong-Huang force-pushed the refactor/move-amber-under-texera branch from 356a020 to ea42805 Compare December 1, 2025 07:50
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a large-scale refactoring to migrate the Amber engine codebase from the org.apache.amber package namespace to org.apache.texera.amber. This change aligns the package structure with the Apache Texera project organization and ensures all components are properly namespaced.

Key Changes:

  • Migrated all source directories across 8 Scala/Java modules from org.apache.amber to org.apache.texera.amber
  • Updated package declarations in 576 Scala/Java files
  • Updated 57 Python files to use new proto import paths
  • Modified 14 Protobuf files with new Java package declarations
  • Updated configuration files and string literals containing class names for reflection/dynamic loading

Reviewed changes

Copilot reviewed 293 out of 709 changed files in this pull request and generated no comments.

Show a summary per file
File Description
cluster.conf Updated Kryo serializer configuration to reference new package namespace
Test files (Scala) Updated package declarations and imports across all test files
Main source files (Scala) Updated package declarations and imports across engine, architecture, and utility classes
Python files Updated proto imports to reflect new namespace structure
WorkerSpec.scala Updated class name string literal for dynamic loading of DummyOperatorExecutor

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@chenlica chenlica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yicong-Huang Yicong-Huang merged commit e8c80c6 into main Dec 1, 2025
10 checks passed
@Yicong-Huang Yicong-Huang deleted the refactor/move-amber-under-texera branch December 1, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common engine frontend Changes related to the frontend GUI python refactor Refactor the code service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-package amber under texera

2 participants