-
Notifications
You must be signed in to change notification settings - Fork 111
feat(ui): add pagination and search for wide-column tables #4086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(ui): add pagination and search for wide-column tables #4086
Conversation
…that the result panel trying to show it and schema propagation are going so slow it crashes the system
…and right column shift, and a search bar
|
@kunwp1 Please review this PR. Check if test cases are needed. I will also review it. |
…7Ball/texera into Ball-FileUpload-WorkingWithFatTables
|
I suggest to add @aglinxinyuan to review the UI change. |
kunwp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments. Also, please add a video or screenshot of the UI change on the PR description.
...rc/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html
Show resolved
Hide resolved
...rc/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html
Outdated
Show resolved
Hide resolved
amber/src/main/scala/org/apache/texera/web/service/ExecutionResultService.scala
Outdated
Show resolved
Hide resolved
...-operator/src/main/scala/org/apache/amber/operator/source/scan/csv/CSVScanSourceOpDesc.scala
Outdated
Show resolved
Hide resolved
...-operator/src/main/scala/org/apache/amber/operator/source/scan/csv/CSVScanSourceOpExec.scala
Outdated
Show resolved
Hide resolved
...kflow-core/src/main/scala/org/apache/amber/core/storage/result/iceberg/IcebergDocument.scala
Outdated
Show resolved
Hide resolved
...ore/src/main/scala/org/apache/texera/amber/core/storage/result/iceberg/IcebergDocument.scala
Show resolved
Hide resolved
common/workflow-core/src/main/scala/org/apache/amber/core/storage/model/VirtualDocument.scala
Outdated
Show resolved
Hide resolved
kunwp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I added some minor comments. Once you address them, @aglinxinyuan can have a second pass to review the UI.
...core/src/main/scala/org/apache/texera/amber/core/storage/model/ReadonlyVirtualDocument.scala
Show resolved
Hide resolved
.../src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts
Show resolved
Hide resolved
…param in getRange(...) and made the column limit displayed on the result panel a configurable parameter
aglinxinyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left mirror comments.
|
|
||
| export const DEFAULT_WIDTH = 800; | ||
| export const DEFAULT_HEIGHT = 300; | ||
| export const DEFAULT_HEIGHT = 500; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep the height at 300? Taking space from another component doesn’t seem like a good way to address the issue.
| <div | ||
| class="column-navigation" | ||
| style="margin-bottom: 8px; display: flex; justify-content: flex-end; gap: 8px"> | ||
| <button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we hide those two buttons when there are just a few columns? We don't need those when there are just three columns.
|
@Ma77Ball Please let us know after you have addressed all the comments. Then we can merge this PR. |
What changes were proposed in this PR?
This PR adds a feature that enables Texera to efficiently handle tables with vast numbers of columns in the result panel.
This PR adds UI features that enable Texera to efficiently handle tables with large numbers of columns in the result viewer and related data preview components.
Specifically, this PR introduces:
Any related issues, documentation, or discussions?
Fixes: #3825
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?
No
New Layout: