Add environment variable injection for SOAP and WSDL endpoints #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SOAP endpoints
This is to unit test environment variable extraction during build time.
Used to mock environment variable injection setting during build-time
Delete external library inclusions & add environment variables via surefire
Code to be verified in PR
To check unit tests during build time
n-jay
commented
Apr 25, 2022
modules/core/src/main/java/org/apache/synapse/config/xml/endpoints/AddressEndpointFactory.java
Outdated
Show resolved
Hide resolved
n-jay
commented
Apr 25, 2022
| extractedEnvVariableValue); | ||
| endpointDefinition.setAddress(extractedEnvVariableValue); | ||
| } else { | ||
| endpointDefinition.setAddress(extractedAddress); |
Member
Author
There was a problem hiding this comment.
Remove the no. of variables and remove the else condition
Member
Author
|
Code review conducted. Changes requested:
|
Pending correction upon code review
Amended line changes to earlier state in EndpointFactories
Rename method and make it static
New method used for retrieving RAW parameters for serialization
isudana
requested changes
Sep 25, 2022
modules/core/src/main/java/org/apache/synapse/config/xml/endpoints/AddressEndpointFactory.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/synapse/config/xml/endpoints/utils/ConfigUtils.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/synapse/endpoints/EndpointDefinition.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/synapse/endpoints/WSDLEndpoint.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/synapse/endpoints/WSDLEndpoint.java
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/synapse/endpoints/WSDLEndpoint.java
Outdated
Show resolved
Hide resolved
modules/core/src/main/java/org/apache/synapse/config/xml/endpoints/AddressEndpointFactory.java
Show resolved
Hide resolved
Assign fetchEnvVariable function to this.address
isudana
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add environment variable injection capability to SOAP and WSDL endpoints.
Approach
Amended AddressEndpointFactory & WSDLEndpointFactory classes to extract environment variables via
System.getenv()based on $SYSTEM prefix presence in the Synapse config XML uri elements.Automation Tests
Unit tests
Covers code written in AddressEndpointFactory.
Integration tests
N/A
Test environment
Learning
A medium post describing the context of the project is linked here.