You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lukaszlenart there is a problem with the refactoring here that I only caught now. The reportUri has been modified to automatically include the servlet context! This is the wrong thing to do for the (many of us) that send our reportUri's to an external service to monitor them. I use an absolute URL, and this is breaking it.
@lukaszlenart ok, I did figure out that there is another variable, prependServletContext, that can be set to false to prevent this behavior. I guess I question setting the default to true, particularly if someone already put in an absolute URL. But at least things can work.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lukaszlenart
requested review from
rgielen,
aleksandr-m,
yasserzamani,
sdutry and
kusalk
asfgit
force-pushed
the
feature/WW-5400-refactor
branch
from
Small refactoring of how
CspSettingsclass is created plus additional tests. See #913 for more details.Closes WW-5400