Skip to content

Add basic LocalDateTime support WW-5175 #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2022
Merged

Add basic LocalDateTime support WW-5175 #554

merged 2 commits into from
May 23, 2022

Conversation

gregh3269
Copy link
Contributor

Reviewed what I had done before, and here is another patch.

org.apache.struts2.components.Date.DATETAG_PROPERTY override, and localdate/localtime.

@coveralls
Copy link

coveralls commented May 19, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 50.634% when pulling 226a1d4 on gregh3269:More_localdatetime_support into 7e91274 on apache:master.

lukaszlenart
lukaszlenart approved these changes May 19, 2022 •
edited
Loading
View reviewed changes
@lukaszlenart
Copy link
Member

There are test errors with testLocalDateTime1Type on Java 9 and 11

@gregh3269
Copy link
Contributor Author

gregh3269 commented May 20, 2022 •
edited
Loading

jdk11 errors something to do with -Djava.locale.providers=COMPAT,CLDR.

@lukaszlenart lukaszlenart merged commit 2cbe472 into apache:master May 23, 2022
@gregh3269 gregh3269 deleted the More_localdatetime_support branch June 8, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukaszlenart lukaszlenart lukaszlenart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregh3269 @coveralls @lukaszlenart