Skip to content

WW-4749: Buffer/Flush behaviour in FreemarkerResult #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 10, 2017
Merged

WW-4749: Buffer/Flush behaviour in FreemarkerResult #134

merged 9 commits into from
May 10, 2017

Conversation

lukaszlenart
Copy link
Member

Implements WW-4749

fustaki
fustaki suggested changes May 10, 2017
View reviewed changes
Copy link

@fustaki fustaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that "useBufferedWriter" has been changed with "writeIfCompleted" for backward compatibility, just for the sake of code readability, I would change the name of the local variable "willUseBufferedWriter" with "willWriteIfCompleted"

@lukaszlenart
Copy link
Member Author

@fustaki done, are we ok?

@fustaki
Copy link

fustaki commented May 10, 2017

Great, OK for me

@asfgit asfgit merged commit b842a4c into apache:master May 10, 2017
@lukaszlenart lukaszlenart deleted the buffer-flush branch May 10, 2017 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@fustaki fustaki fustaki requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszlenart @fustaki @asfgit