[ISSUE #9623] Fix Failing Tests In MessageStoreWithFilterTest #9624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crazylychee
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #9624 +/- ##
=============================================
- Coverage 48.15% 48.06% -0.10%
+ Complexity 12083 12057 -26
=============================================
Files 1313 1313
Lines 92839 92839
Branches 11870 11870
=============================================
- Hits 44710 44619 -91
- Misses 42636 42707 +71
- Partials 5493 5513 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # broker/src/test/java/org/apache/rocketmq/broker/filter/MessageStoreWithFilterTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #9623
Brief Description
In the original MessageStoreWithFilterTest class, when testing in a local Windows environment, MixAll's file deletion method failed to delete the commitlog files left over from previous tests. This caused tests to interfere with each other, leading to failures and inconsistent test results.
This pull request primarily aims to isolate the data for these tests, storing them in independent directories and releasing resources at the end, ensuring that local tests can pass.
How Did You Test This Change?