Skip to content

Fix unit test issue in BrokerServiceTest.java #6006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2020
Merged

Fix unit test issue in BrokerServiceTest.java #6006

merged 1 commit into from
Jan 8, 2020

Conversation

codelipenghui
Copy link
Contributor

Motivation

Since #5599 merged, it introduce some conflict code with master branch, maybe the reason is #5599 not rebase with master

Verifying this change

This is a test change

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@codelipenghui codelipenghui self-assigned this Jan 7, 2020
@sijie sijie added this to the 2.6.0 milestone Jan 7, 2020
@sijie sijie added area/test type/bug The PR fixed a bug or issue reported a bug labels Jan 7, 2020
@codelipenghui
Copy link
Contributor Author

run java8 tests

@codelipenghui
Copy link
Contributor Author

rerun java8 tests

@sijie
Copy link
Member

sijie commented Jan 8, 2020

run java8 tests

1 similar comment
@codelipenghui
Copy link
Contributor Author

run java8 tests

@jiazhai jiazhai merged commit 275854e into apache:master Jan 8, 2020
@tuteng
Copy link
Member

tuteng commented Feb 23, 2020

Add label release/2.5.1, due error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project pulsar-broker: Compilation failure: Compilation failure:
[ERROR] /pulsar/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java:[949,86] cannot find symbol
[ERROR]   symbol:   method get(int)
[ERROR]   location: interface java.util.Collection<org.apache.pulsar.broker.service.Producer>
[ERROR] /pulsar/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/BrokerServiceTest.java:[951,24] cannot find symbol
[ERROR]   symbol:   method add(org.apache.pulsar.broker.service.Producer)
[ERROR]   location: variable producers of type java.util.concurrent.ConcurrentHashMap<java.lang.String,org.apache.pulsar.broker.service.Producer>
[ERROR] -> [Help 1]

tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Feb 23, 2020
@codelipenghui @tuteng
Fix unit test (apache#6006)
c9035ea 
### Motivation

Since apache#5599 merged, it introduce some conflict code with master branch, maybe the reason is apache#5599 not rebase with master

### Verifying this change

This is a test change
tuteng pushed a commit to AmateurEvents/pulsar that referenced this pull request Mar 21, 2020
@codelipenghui @tuteng
Fix unit test (apache#6006)
f3ca73f 
### Motivation

Since apache#5599 merged, it introduce some conflict code with master branch, maybe the reason is apache#5599 not rebase with master

### Verifying this change

This is a test change

(cherry picked from commit 275854e)
tuteng pushed a commit that referenced this pull request Apr 13, 2020
@codelipenghui @tuteng
Fix unit test (#6006)
07006d5 
### Motivation

Since #5599 merged, it introduce some conflict code with master branch, maybe the reason is #5599 not rebase with master

### Verifying this change

This is a test change

(cherry picked from commit 275854e)
jiazhai pushed a commit to jiazhai/pulsar that referenced this pull request May 18, 2020
@codelipenghui @jiazhai
Fix unit test (apache#6006)
be92eb5 
### Motivation

Since apache#5599 merged, it introduce some conflict code with master branch, maybe the reason is apache#5599 not rebase with master

### Verifying this change

This is a test change

(cherry picked from commit 275854e)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
@codelipenghui @huangdx0726
Fix unit test (apache#6006)
f060c58 
### Motivation

Since apache#5599 merged, it introduce some conflict code with master branch, maybe the reason is apache#5599 not rebase with master

### Verifying this change

This is a test change
@codelipenghui codelipenghui deleted the test_issue branch May 19, 2021 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@jiazhai jiazhai jiazhai approved these changes

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

Assignees

@codelipenghui codelipenghui

Labels
area/test release/2.5.1 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@codelipenghui @sijie @tuteng @jiazhai