Skip to content

Using Auto Consume consumer on a topic that doesn't have a schema doesn't work #3909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Using Auto Consume consumer on a topic that doesn't have a schema doesn't work #3909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...tion/src/test/java/org/apache/pulsar/tests/integration/functions/PulsarFunctionsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ private void testExclamationFunction(Runtime runtime,
}

// get function status
getFunctionStatus(functionName, numMessages);
getFunctionStatus(functionName, numMessages, true);

// get function stats
getFunctionStats(functionName, numMessages);
Expand Down Expand Up @@ -964,7 +964,7 @@ private static void checkSubscriptionsCleanup(String topic) throws Exception {
}
}

private static void getFunctionStatus(String functionName, int numMessages) throws Exception {
private static void getFunctionStatus(String functionName, int numMessages, boolean checkRestarts) throws Exception {
ContainerExecResult result = pulsarCluster.getAnyWorker().execCmd(
PulsarCluster.ADMIN_SCRIPT,
"functions",
Expand All @@ -985,7 +985,9 @@ private static void getFunctionStatus(String functionName, int numMessages) thro
assertTrue(functionStatus.getInstances().get(0).getStatus().getLastInvocationTime() > 0);
assertEquals(functionStatus.getInstances().get(0).getStatus().getNumReceived(), numMessages);
assertEquals(functionStatus.getInstances().get(0).getStatus().getNumSuccessfullyProcessed(), numMessages);
assertEquals(functionStatus.getInstances().get(0).getStatus().getNumRestarts(), 0);
if (checkRestarts) {
assertEquals(functionStatus.getInstances().get(0).getStatus().getNumRestarts(), 0);
}
assertEquals(functionStatus.getInstances().get(0).getStatus().getLatestUserExceptions().size(), 0);
assertEquals(functionStatus.getInstances().get(0).getStatus().getLatestSystemExceptions().size(), 0);
}
Expand Down Expand Up @@ -1121,8 +1123,9 @@ public void testAutoSchemaFunction() throws Exception {
// publish and consume result
publishAndConsumeAvroMessages(inputTopicName, outputTopicName, numMessages);

// get function status
getFunctionStatus(functionName, numMessages);
// get function status. Note that this function might restart a few times until
// the producer above writes the messages.
getFunctionStatus(functionName, numMessages, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why will this restart a couple of times? That doesn't sound like the correct behavior


// delete function
deleteFunction(functionName);
Expand Down