Skip to content

Refactored ReplicatorTest to be more easily debuggable #3892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2019
Merged

Refactored ReplicatorTest to be more easily debuggable #3892

merged 1 commit into from
Mar 25, 2019

Conversation

merlimat
Copy link
Contributor

Motivation

Based on the debugging done for #3888, simplified the code in ReplicatorTest to make it easier to get the cause of errors.

  • Re-enabled some of the previously disabled tests
  • Moved the V1 test as a case in the regular replicator test

@merlimat merlimat added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/test labels Mar 24, 2019
@merlimat merlimat self-assigned this Mar 24, 2019
@merlimat merlimat added this to the 2.4.0 milestone Mar 24, 2019
@merlimat merlimat merged commit 1921bd9 into apache:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sijie sijie sijie approved these changes

@ivankelly ivankelly Awaiting requested review from ivankelly

@srkukarni srkukarni Awaiting requested review from srkukarni

@rdhabalia rdhabalia Awaiting requested review from rdhabalia

@jerrypeng jerrypeng Awaiting requested review from jerrypeng

@nkurihar nkurihar Awaiting requested review from nkurihar

@massakam massakam Awaiting requested review from massakam

Assignees

@merlimat merlimat

Labels
area/test type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@merlimat @sijie