Encode client version into Java source file instead of pulsar-client-version.properties #3880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version.properties
merlimat
added
the
type/enhancement
|
run java8 tests |
1 similar comment
|
run java8 tests |
rdhabalia
approved these changes
Mar 23, 2019
|
run java8 tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the client version is being reported from a properties files that is included in the pulsar client Jar. If the application is packaging this into an uber-jar on its own, it might be stripping away the properties file and we won't be able to track the client version.
Instead, expand the property into a Java template file where it will be more safely stored.