Skip to content

[Issue 3475][pulsar-client] Add cluster checking before operating tenants with it #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 17, 2019
Merged

[Issue 3475][pulsar-client] Add cluster checking before operating tenants with it #3476

merged 10 commits into from
May 17, 2019

Conversation

murong00
Copy link
Contributor

Motivation

Fix #3475

Modifications

Add cluster checking before operating tenants with it.

merlimat
merlimat reviewed Jan 29, 2019
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murong00 I think it would be better to do the check on server side rather than in CLI tool. This way it would be strictly enforced and the error will be sent to REST, Java admin client lib and CLI tool.

@murong00
Copy link
Contributor Author

@merlimat Thanks, I will fix it later.

@sijie sijie added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/cli labels Feb 4, 2019
@murong00
Copy link
Contributor Author

@merlimat @sijie PTAL, thanks!

@sijie
Copy link
Member

sijie commented Apr 22, 2019

run java8 tests

@murong00
Copy link
Contributor Author

murong00 commented May 8, 2019

run java8 tests

@merlimat merlimat added this to the 2.4.0 milestone May 8, 2019
merlimat
merlimat approved these changes May 8, 2019
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merlimat merlimat merged commit 4eaff7a into apache:master May 17, 2019
@murong00 murong00 deleted the branch-3476 branch March 8, 2020 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat approved these changes

@sijie sijie sijie approved these changes

Assignees

@murong00 murong00

Labels
area/cli type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.

Create or update tenants with clusters that do not exist should not be allowed
3 participants
@murong00 @sijie @merlimat