[fix][client] Fix concurrent lookup with properties might have different results #23260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
codelipenghui,
RobertIndie and
poorbarcode
RobertIndie
approved these changes
Sep 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23260 +/- ##
============================================
+ Coverage 73.57% 74.53% +0.96%
- Complexity 32624 34292 +1668
============================================
Files 1877 1926 +49
Lines 139502 145043 +5541
Branches 15299 15862 +563
============================================
+ Hits 102638 108111 +5473
+ Misses 28908 28683 -225
- Partials 7956 8249 +293
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nodece
approved these changes
Sep 6, 2024
michalcukierman
pushed a commit
to michalcukierman/pulsar
that referenced
this pull request
Sep 11, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
|
@BewareMyPower Is this a bug fix that should be cherry-picked to branch-3.0? |
|
No, the lookup properties feature was introduced from PIP-368 (#23075), which is only included in 4.0 or later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the lookup properties are modified, the previous pending lookup might use the modified properties for lookup.
Modifications
ClientConfigurationData#getPropertiestestConcurrentLookupPropertiesto cover this case.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: