[improve][broker] Add fine-grain authorization to retention admin API #22163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fine-grain authorization to retention admin API so that it can be controlled at a more fine-grain level. - Update getRetention, add PolicyName.RETENTION with READ check - Update setRetention & removeRetention, add PolicyName.RETENTION with WRITE check
mattisonchao
requested review from
Technoboy-,
codelipenghui,
eolivelli and
lhotari
lhotari
approved these changes
Feb 29, 2024
Member
lhotari
left a comment
lhotari
left a comment
There was a problem hiding this comment.
LGTM. Good work @mattisonchao
Technoboy-
approved these changes
Feb 29, 2024
dao-jun
approved these changes
Feb 29, 2024
Contributor
|
@mattisonchao We have a conflict in branch-3.0. can you help to cherry-pick this to branch-3.0? |
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 4, 2024
…apache#22163) (cherry picked from commit 6ec473e) (cherry picked from commit 4f2e4c8)
mattisonchao
added a commit
that referenced
this pull request
Mar 4, 2024
mukesh-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 6, 2024
…apache#22163) (cherry picked from commit 6ec473e) (cherry picked from commit 4f2e4c8)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
…apache#22163) (cherry picked from commit 6ec473e) (cherry picked from commit 0256117)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
(cherry picked from commit 4b5dba7)
nikhil-ctds
added a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
4 tasks
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
…apache#22163) (cherry picked from commit 6ec473e) (cherry picked from commit 0256117)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
(cherry picked from commit 4b5dba7)
nikhil-ctds
added a commit
to datastax/pulsar
that referenced
this pull request
Mar 11, 2024
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add fine-grain authorization to retention admin API so that it can be controlled at a more fine-grain level.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
Documentation
doc-not-needed