Skip to content

Conversation

@aloyszhang
Copy link
Contributor

@aloyszhang aloyszhang commented Sep 13, 2023

Fixes #21174

Motivation

Make sure brokers will read a balanced state when using UnifromLoadShedder

Modifications

  1. Add new placement strategy: UniformLoadManagerStrategy which support load placement base on
    • long-term msgRate or msgThroughput
    • short-term msgRate or msgThroughput
  2. Keep compatible with the exist configuration loadBalancerLoadPlacementStrategy=org.apache.pulsar.broker.loadbalance.impl.LeastLongTermMessageRate
  3. Support dynamically configurable for all these placement strategies
  4. Add a test to cover this change

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:aloyszhang#20

@github-actions
Copy link

@aloyszhang Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@aloyszhang aloyszhang modified the milestones: 3.1.0, 3.2.0 Sep 22, 2023
@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Sep 22, 2023
@aloyszhang aloyszhang closed this Sep 22, 2023
@aloyszhang aloyszhang reopened this Sep 22, 2023
@github-actions
Copy link

The pr had no activity for 30 days, mark with Stale label.

@github-actions github-actions bot added the Stale label Oct 23, 2023
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.3.0 Dec 22, 2023
@coderzc coderzc modified the milestones: 3.3.0, 3.4.0 May 8, 2024
@lhotari lhotari modified the milestones: 4.0.0, 4.1.0 Oct 11, 2024
@lhotari lhotari removed this from the 4.1.0 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Brokers can't reach balanced state sometimes when using UnifromLoadShedder

4 participants