Skip to content

Conversation

stepanbujnak
Copy link
Contributor

Motivation

The message payload is optional and in some cases only message properties are sent. In this case, the message decompression would fail.

Modifications

Only do the decompression if the payload is not empty.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable
  • If a feature is not applicable for documentation, explain why? it's just a bugfix
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

The message payload is optional and in some cases only message
properties are sent. In this case, the message decompression would fail
so we only want to do the decompression if the payload is not empty.
@nodece nodece requested a review from crossoverJie October 2, 2024 08:56
Copy link
Member

@crossoverJie crossoverJie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crossoverJie crossoverJie added this to the v0.15.0 milestone Oct 4, 2024
@nodece nodece merged commit 69a06d5 into apache:master Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants