[Issue 1218][Reader] Reader Next returns on closed consumer #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilthoniel
force-pushed
the
feature/reader-next-close
branch
from
bd5e740 to
ae1cfc7
Compare
Signed-off-by: Gaylor Bosson <[email protected]>
Gilthoniel
force-pushed
the
feature/reader-next-close
branch
from
ae1cfc7 to
817812e
Compare
RobertIndie
approved these changes
May 16, 2024
hezhangjian
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1218
Motivation
Calling Next on a reader already closed will block forever unless the context is canceled. Similarly, the call will not return if a different go routine closes the reader.
Modifications
Next now listens for the close channel of the consumer to return an error when it closes.
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
None