[fix] [issue 1064] Fix the panic when try to flush in DisableBatching=true #1065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
approved these changes
Jul 23, 2023
RobertIndie
approved these changes
Jul 25, 2023
This was referenced Aug 3, 2023
RobertIndie
pushed a commit
that referenced
this pull request
Sep 7, 2023
…=true (#1065) Fixes #1064 ### Motivation If we set producer `DisableBatching=true`, it will be panic when call `producer.Flush()`. More details in #1064 . ### Modifications - Avoid panic in non-batching producer - Add unit test to cover `Flush()` in non-batching producer. (cherry picked from commit 4bfd4aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1064
Motivation
If we set producer
DisableBatching=true, it will be panic when callproducer.Flush(). More details in #1064 .Modifications
Flush()in non-batching producer.Verifying this change