-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[Auto reset 2/3]Introduce topic 'inactive' status #16692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auto reset 2/3]Introduce topic 'inactive' status #16692
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #16692 +/- ##
============================================
+ Coverage 63.33% 63.36% +0.02%
- Complexity 1379 1380 +1
============================================
Files 3036 3036
Lines 176785 177006 +221
Branches 27131 27150 +19
============================================
+ Hits 111971 112152 +181
- Misses 56227 56248 +21
- Partials 8587 8606 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pinot-controller/src/main/java/org/apache/pinot/controller/helix/SegmentStatusChecker.java
Show resolved
Hide resolved
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/PauseState.java
Outdated
Show resolved
Hide resolved
@lnbest0707-uber can you check if the test failures are related? |
Pinot Binary Compatibility Check (pull_request) is due to changing the constructor. But since we will use the new and discontinue using the old. I feel I should remove the old instead keeping both. The integration test succeeds on Java21 and should be flaky. |
real-time
ingestion
feature
Part 2 of #15782, but this is independent from part 1
Issue #14815
Design doc https://docs.google.com/document/d/1NKPeNh6V2ctaQ4T_X3OKJ6Gcy5TRanLiU1uIDT8_9UA/edit?usp=sharing
This is an alternative PR of #16494
Instead of introducing the new segment naming format that concerns some parties, this PR chooses the way to "soft delete" the topics by marking it as 'inactive'.
We still cannot literally delete a topic from the table config.
But instead, we would introduce a similar "pause" consumption API to mark topic as 'inactive' in the idealstae. As a result, the consumption of the topic would stop.
This 'inactive' marking would also prevent the metadata being queries from the stream. So that it would be safe to delete the topic from the stream.
The table idealstate could look like (with
pauseState
field an additional key added)