Skip to content

Conversation

deemoliu
Copy link
Contributor

@deemoliu deemoliu commented Aug 22, 2025

Instructions:
This PR add uniqueNgramsMV UDFs to generate ngrams on mv columns and add minor refactor to uniqueNgrams
#12392

How to use

        {
          "columnName": "col_ngrams",
          "transformFunction": "uniqueNgramMV(col, 3)"
        },
        {
          "columnName": "col_1gram_2gram_3gram",
          "transformFunction": "uniqueNgramMV(col, 1, 3)"
        },

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2025

Codecov Report

❌ Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.37%. Comparing base (76f2b7f) to head (8072494).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
.../common/function/scalar/string/NgramFunctions.java 84.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16671      +/-   ##
============================================
+ Coverage     63.32%   63.37%   +0.05%     
  Complexity     1380     1380              
============================================
  Files          3035     3035              
  Lines        176714   176753      +39     
  Branches      27121    27129       +8     
============================================
+ Hits         111896   112020     +124     
+ Misses        56232    56153      -79     
+ Partials       8586     8580       -6     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-11 63.31% <84.00%> (+0.03%) ⬆️
java-21 63.34% <84.00%> (+0.04%) ⬆️
temurin 63.37% <84.00%> (+0.05%) ⬆️
unittests 63.37% <84.00%> (+0.05%) ⬆️
unittests1 56.48% <84.00%> (+0.02%) ⬆️
unittests2 33.15% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants