This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-455: Fix OS X / Clang compiler warnings #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| uint32_t metadata_len = *reinterpret_cast<uint32_t*>(footer_buffer); | ||
| size_t metadata_start = filesize - FOOTER_SIZE - metadata_len; | ||
| if (metadata_start < 0) { | ||
| if (FOOTER_SIZE + metadata_len > filesize) { |
Member
There was a problem hiding this comment.
metadata_start < 0
<=> filesize - FOOTER_SIZE - metadata_len < 0
<=> filesize < FOOTER_SIZE + metadata_len
<=> FOOTER_SIZE + metadata_len > filesize
right?
Member
|
LGTM, +1 |
Member
Author
|
Cool, fire when ready. Thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There actually was a legitimate bug fixed here for malformed Parquet files, but we are not yet in a position to write a decent test for it until PARQUET-497. I will make a note on that JIRA.
I also set our Travis CI build to fail on future compiler warnings.
This also closes #15.