This repository was archived by the owner on May 10, 2024. It is now read-only.
PARQUET-915: Support Arrow Time Types #270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you
Thanks |
wesm
referenced
this pull request
Mar 13, 2017
At the moment this is just move of the existing code into the state where it compiles. Outstanding work includes: - [x] Understand the issues with ParquetException typeid matching in the tests *on macOS*. @wesm We already had this problem and you fixed it somewhere. Do you remember the solution? - [x] Understand why BoolenType tests break with a Thrift exception - [ ] Add functions that read directly into Arrow memory and not intermediate structures. Author: Uwe L. Korn <[email protected]> Author: Korn, Uwe <[email protected]> Closes #158 from xhochy/PARQUET-712 and squashes the following commits: e55ab1f [Uwe L. Korn] verbose ctest output 62f0f88 [Uwe L. Korn] Add static linkage fc2c316 [Uwe L. Korn] Style fixes 3f3e24b [Uwe L. Korn] Fix templating problem 45de044 [Uwe L. Korn] Style fixes for IO 1d39a60 [Uwe L. Korn] Import MemoryPool instead of declaring it 251262a [Uwe L. Korn] Style fixes e0e1518 [Uwe L. Korn] Build parquet_arrow in Travis 874b33d [Korn, Uwe] Add boost libraries for Arrow 142a364 [Korn, Uwe] PARQUET-712: Add library to read into Arrow memory
tebeka
changed the title
tebeka
changed the title
wesm
reviewed
Mar 14, 2017
src/parquet/arrow/reader.cc
Outdated
| return TypedReadBatch<::arrow::TimeType, Int64Type>(batch_size, out); | ||
| break; | ||
| default: | ||
| return UnsupportedTimeUnit(time_type->unit); |
Member
There was a problem hiding this comment.
Since we don't have any tests for reading time columns, can you leave this case not implemented?
Member
There was a problem hiding this comment.
The time type is undergoing discussion in https://issues.apache.org/jira/browse/ARROW-617 so most likely these will have to be revisited after the time type is finalized in the Arrow format.
Author
There was a problem hiding this comment.
OK. Will remove this code then :)
ARROW-601: Some logical types not supported when loading Parquet Support for TimeType with TimeUnit::MILLI and TimeUnit::MICRO
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.