ORC-1738: [C++] Fix wrong Int128 maximum value #1970
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Letian Jiang <[email protected]>
ffacs
changed the title
wgtmac
approved these changes
Jul 8, 2024
Contributor
|
It's an issue from day one; perhaps we should consider cherry-picking it into branch-1.0. |
dongjoon-hyun
approved these changes
Jul 9, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Yes, +1 for backporting for all live release branches.
- master
- branch-2.0
- branch-1.9
- branch-1.8
- branch-1.7
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 9, 2024
### What changes were proposed in this pull request? ### Why are the changes needed? The low part of Int128::maximumValue is wrong. In hex format, it should be 0xffffffffffffffff rather than 0xfffffffffffffff, in which one f is dropped by mistake. ### How was this patch tested? I have added the relevant unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1970 from letian-jiang/fix-128-max. Authored-by: Letian Jiang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9af09ec) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 9, 2024
### What changes were proposed in this pull request? ### Why are the changes needed? The low part of Int128::maximumValue is wrong. In hex format, it should be 0xffffffffffffffff rather than 0xfffffffffffffff, in which one f is dropped by mistake. ### How was this patch tested? I have added the relevant unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1970 from letian-jiang/fix-128-max. Authored-by: Letian Jiang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9af09ec) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 9, 2024
### What changes were proposed in this pull request? ### Why are the changes needed? The low part of Int128::maximumValue is wrong. In hex format, it should be 0xffffffffffffffff rather than 0xfffffffffffffff, in which one f is dropped by mistake. ### How was this patch tested? I have added the relevant unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1970 from letian-jiang/fix-128-max. Authored-by: Letian Jiang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9af09ec) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 9, 2024
### What changes were proposed in this pull request? ### Why are the changes needed? The low part of Int128::maximumValue is wrong. In hex format, it should be 0xffffffffffffffff rather than 0xfffffffffffffff, in which one f is dropped by mistake. ### How was this patch tested? I have added the relevant unit tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #1970 from letian-jiang/fix-128-max. Authored-by: Letian Jiang <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9af09ec) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Welcome to the Apache ORC community, @letian-jiang . |
Member
|
cc @williamhyun too because he is a release manager of ORC 1.9.4. |
This was referenced Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
The low part of Int128::maximumValue is wrong. In hex format, it should be 0xffffffffffffffff rather than 0xfffffffffffffff, in which one f is dropped by mistake.
How was this patch tested?
I have added the relevant unit tests.
Was this patch authored or co-authored using generative AI tooling?
No.