ORC-1733: [C++][CMake] Fix CMAKE_MODULE_PATH not to use PROJECT_SOURCE_DIR #1959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kou
approved these changes
Jun 23, 2024
Member
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
See also: apache/arrow#43011 (comment)
wgtmac
added a commit
that referenced
this pull request
Jun 25, 2024
…E_DIR
Change `PROJECT_SOURCE_DIR` to `CMAKE_CURRENT_SOURCE_DIR` for `CMAKE_MODULE_PATH`.
Line below is not portable when ORC is used by downstream projects:
```
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${PROJECT_SOURCE_DIR}/cmake_modules")
```
Make sure all CIs pass.
No.
Closes #1959 from wgtmac/ORC-1733.
Authored-by: Gang Wu <[email protected]>
Signed-off-by: Gang Wu <[email protected]>
(cherry picked from commit 2609934)
Signed-off-by: Gang Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change
PROJECT_SOURCE_DIRtoCMAKE_CURRENT_SOURCE_DIRforCMAKE_MODULE_PATH.Why are the changes needed?
Line below is not portable when ORC is used by downstream projects:
How was this patch tested?
Make sure all CIs pass.
Was this patch authored or co-authored using generative AI tooling?
No.