Skip to content

Conversation

pvillard31
Copy link
Contributor

Summary

NIFI-14998 - Bump Log4J2 to 2.25.2, Guava to 33.5.0-jre, Mockito to 5.20.0, and others

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on these upgrades @pvillard31.

Regarding the Guava version, this has not previously been set at the root level due to incompatible changes in various modules. This seems to be less of an issue with recent versions of Guava. However, Guava should be avoided in general, so leaving the version in particular modules help keep the dependency isolated. For these reasons, I recommend reverting the root-level version change and keeping the Guava version property in the previous locations.

@pvillard31
Copy link
Contributor Author

Done, thanks for the feedback @exceptionfactory

@exceptionfactory exceptionfactory merged commit f577ba0 into apache:main Sep 22, 2025
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants