-
Notifications
You must be signed in to change notification settings - Fork 914
Set --sun-misc-unsafe-memory-access=warn (JEP 498) #9021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a585485 to
b00dd10
Compare
b00dd10 to
a732c17
Compare
|
wondering if we should set it in or append to netbeans/nbbuild/templates/projectized.xml Line 333 in b535ff5
Since that way tests would pick it up too. They might start failing at some point. |
- JDK 26 will set it to deny and throw on Unsafe mem access method usage - gives us more time to update the dependencies (till JDK 27) Set -J-Dguice_custom_class_loading=CHILD - this will lead guice to code paths which don't use Unsafe for class definition (e.g it won't use com.google.inject.internal.aop.HiddenClassDefiner) - maven 4 uses the same trick (maven/pull/11002)
|
I have no idea what too choose. JDK 26 will "freeze" change begining december ? |
not sure. JEP states "deny will be the default value in phase 3 (JDK 26 or later)", maybe it won't even be changed in JDK 26 - I don't know. |
|
we could keep it as is and only add it to the |
|
I it's helps go for the more convenient |
a732c17 to
50b6650
Compare
Set --sun-misc-unsafe-memory-access=warn (JEP 498)
warnit todenyand throw onUnsafemem access method usage, this sets it backnote: as of 26b23, this isn't implemented yet
set
-J-Dguice_custom_class_loading=CHILDUnsafefor class definition(e.g it won't use
com.google.inject.internal.aop.HiddenClassDefiner)meta issue #8259