Fixing completion for for-each construct without type.

[lahodaj]

One of my pet peeves is this case with code completion:

Map<String, String> m = ...;
for (e : m.<code-completion-here>)

The CC does not work here - it will simply show nothing. The reason, as far as I can tell is that the end pos for the variable is wrong. lib.nbjavac tries to correct the position, but storeEnd won't let the position to be set before errorEndPos. The main proposal here is to force-set the "correct" end position.

There's also a small tweak in the CC to make the CC work for cases where there is an undefined type like:

List<Undefined> l = ...;
for (Object o : <"l" should be a smart type here, probably?>)

---

^Add meaningful description above

Click to collapse/expand PR instructions

By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -

• are all your own work, and you have the right to contribute them.
• are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).

Please make sure (eg. git log) that all commits have a valid name and email address for you in the Author field.

If you're a first time contributor, see the Contributing guidelines for more information.

If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.

PR approval and merge checklist:

1. Was this PR correctly labeled, did the right tests run? When did they run?
2. Is this PR squashed?
3. Are author name / email address correct? Are co-authors correctly listed? Do the commit messages need updates?
4. Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?

If this PR targets the delivery branch: don't merge. (full wiki article)

[dbalek]

Looks fine.

[mbien]

awesome! (don't forget to squash)