Skip to content

Conversation

@Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented Jun 6, 2025

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] SUMMARY,
    where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
  • Also format the first line of the commit message like [MNG-XXX] SUMMARY.
    Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

follow up:

@Pankraz76 Pankraz76 force-pushed the cleanup-MissingOverride-pmd branch 2 times, most recently from c465dd3 to bb9443f Compare June 6, 2025 16:09
@Pankraz76 Pankraz76 marked this pull request as ready for review June 6, 2025 16:17
@slachiewicz

This comment was marked as resolved.

@slachiewicz slachiewicz marked this pull request as draft June 6, 2025 17:20
@Pankraz76

This comment was marked as resolved.

@Pankraz76 Pankraz76 changed the title [S1161] Add missing @Override to overriding and implementing methods [MNG-S1161] chore: Add missing @Override to overriding and implementing methods Jun 6, 2025
@Pankraz76 Pankraz76 force-pushed the cleanup-MissingOverride-pmd branch from bb9443f to 4a60d39 Compare June 6, 2025 18:31
@Pankraz76 Pankraz76 marked this pull request as ready for review June 6, 2025 18:31
@Pankraz76

This comment was marked as resolved.

@slawekjaranowski

This comment was marked as resolved.

@Pankraz76

This comment was marked as resolved.

@Pankraz76

This comment was marked as off-topic.

@Pankraz76

This comment was marked as off-topic.

@Pankraz76 Pankraz76 changed the title [MNG-S1161] chore: Add missing @Override to overriding and implementing methods [S1161] chore: Add missing @Override to overriding and implementing methods Jun 9, 2025
@Pankraz76 Pankraz76 force-pushed the cleanup-MissingOverride-pmd branch from cc7780f to b72292a Compare June 9, 2025 20:52
@Pankraz76
Copy link
Contributor Author

7 new since last try. kind of need to do this in sync to get it done. @elharo

@Pankraz76 Pankraz76 force-pushed the cleanup-MissingOverride-pmd branch from b72292a to a6061ab Compare June 9, 2025 20:53
@Pankraz76
Copy link
Contributor Author

Pankraz76 commented Jun 9, 2025

Files changed 141

Files changed 148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants