[MNG-8530] Prompter fixes #2086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aligns now what we really want: * maven-core provides Plexus Interactivity API * maven-jline provides Plexus Interactivity API implementation * new Maven4 API Prompter simply delegates to maven-jline one --- https://issues.apache.org/jira/browse/MNG-8530
And now legacy goes for current, and not other way around.
* make sure out prompter override legacy * honor proper exceptions
gnodet
reviewed
Feb 6, 2025
| @Experimental | ||
| @Named | ||
| @Singleton | ||
| @Priority(10) |
Contributor
There was a problem hiding this comment.
@cstamas Would it make sense to move that one to compat/maven-compat ? The idea would be to avoid introducing any new dependency on sisu in impl/* jars ?
|
Resolve #9373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aligns now what we really want:
https://issues.apache.org/jira/browse/MNG-8530