Skip to content

[MNG-8493] 'serialVersionUID' can be annotated with '@Serial' annotation #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

[MNG-8493] 'serialVersionUID' can be annotated with '@Serial' annotation #2034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...src/main/java/org/apache/maven/internal/impl/model/reflection/IntrospectionException.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,14 @@
*/
package org.apache.maven.internal.impl.model.reflection;

import java.io.Serial;

public class IntrospectionException extends Exception {

/**
*
*/
@Serial
private static final long serialVersionUID = -6090771282553728784L;

IntrospectionException(String message) {
Expand Down
2 changes: 2 additions & 0 deletions impl/maven-impl/src/main/java/org/apache/maven/internal/impl/model/reflection/MethodMap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
package org.apache.maven.internal.impl.model.reflection;

import java.io.Serial;
import java.lang.reflect.Method;
import java.util.ArrayList;
import java.util.Hashtable;
Expand Down Expand Up @@ -118,6 +119,7 @@ Method find(String methodName, Object... args) throws AmbiguousException {
*/
static class AmbiguousException extends Exception {

@Serial
private static final long serialVersionUID = 751688436639650618L;
}

Expand Down
2 changes: 0 additions & 2 deletions impl/maven-logging/src/main/java/org/apache/maven/slf4j/MavenBaseLogger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,6 @@
*/
public class MavenBaseLogger extends LegacyAbstractLogger {

private static final long serialVersionUID = -632788891211436180L;

private static final Clock MONOTONIC_CLOCK = Clock.tick(Clock.systemUTC(), Duration.ofMillis(1));
private static final Instant START_TIME = MonotonicClock.now();

Expand Down
2 changes: 2 additions & 0 deletions impl/maven-xml/src/main/java/org/apache/maven/internal/xml/XmlNodeImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

import javax.xml.stream.XMLStreamException;

import java.io.Serial;
import java.io.Serializable;
import java.io.StringWriter;
import java.util.ArrayList;
Expand All @@ -41,6 +42,7 @@
* NOTE: remove all the util code in here when separated, this class should be pure data.
*/
public class XmlNodeImpl implements Serializable, XmlNode {
@Serial
private static final long serialVersionUID = 2567894443061173996L;

protected final String prefix;
Expand Down
Loading