Skip to content

Conversation

@kwin
Copy link
Member

@kwin kwin commented Sep 15, 2025

whatchanged is deprecated and supposed to be removed in future git versions (https://git-scm.com/docs/git-whatchanged). "log" is semantically equivalent except for different default which are anyhow overwritten in this context (skip merge commits, raw output).

This closes #1310

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin kwin requested review from elharo and michael-o September 15, 2025 10:26
whatchanged is deprecated and supposed to be removed in future git
versions (https://git-scm.com/docs/git-whatchanged). "log" is
semantically equivalent except for different default which are anyhow
overwritten in this context (skip merge commits, raw output).

This closes #1310
@kwin kwin force-pushed the feature/replace-git-whatchanged-by-log branch from 55bb026 to 4f3f51e Compare September 15, 2025 10:28
@kwin kwin merged commit ae9b94d into master Sep 15, 2025
36 checks passed
@kwin kwin deleted the feature/replace-git-whatchanged-by-log branch September 15, 2025 11:58
@github-actions github-actions bot added this to the 2.2.1 milestone Sep 15, 2025
@github-actions
Copy link

@kwin Please assign appropriate label to PR according to the type of change.

@kwin kwin added the bug Something isn't working label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changelog command uses deprecated git whatchanged leading to flaky Tests on Mac OS X

2 participants