-
Notifications
You must be signed in to change notification settings - Fork 136
RFC9457 implementation #1502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC9457 implementation #1502
Conversation
@doddi I would like to change a title of PR to something more descriptive ... like example: it will be used in release notes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash and use the original commit summary
No need for squashing, as we do it anyway (on GH UI or locally), no? |
fb1ccfd
to
24f8135
Compare
Easy enough to do anyway 👍 |
What would be the process for getting a maven-resolver release done for this change so that it can go into the next maven 3.9.x release? |
It should happen. We plan 3.9.11 soon, and resolver 1.x has some other update prs scheduled as well. |
We need also change commit message ... so quash on GitHub UI will be the easier |
@michael-o the commit subject and message from will be ok for you? |
Exactly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit summary and message aren't still right
Will be - after squash in GitHub |
How? GH knows nothing about the commit on master. |
backport of change 92b46ba Added an RFC9457Reporter for HttpTransporter At the moment, I tried to keep the original exception messages if the error response is not an [RFC9457](https://www.rfc-editor.org/rfc/rfc9457) type. This did create a little more complexity in the implementation than is perhaps necessary. If the exceptions to be thrown can be consisted throughout the transporters, then this PR could also be simplified considerably. At the moment, I have taken the stance not to make any potential breaking changes in messaging.
24f8135
to
d657c80
Compare
@michael-o done in PR |
615eab3
into
apache:maven-resolver-1.9.x
This PR is a backport of #576 which was an implementation of RFC9457 which adds problem information as a payload. Previously, the reasonPhrase prior to http2 could be used to provide extra information but since http2 this has been dropped.
The backport is required because maven 3.9.x is pinning maven-resolver to 1.9.x
. The previous work was released in 2.0.2.
Slack conversation: https://the-asf.slack.com/archives/C7Q9JB404/p1750487298498529?thread_ts=1750487298.498529&cid=C7Q9JB404
Fixes: #1501
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verify
to make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.