Skip to content

Conversation

@gnodet
Copy link
Contributor

@gnodet gnodet commented Feb 4, 2022

The goal is that a subsequent maven build will not touch the jars at all. In order to achieve that, the manifest is build in a separate directory and moved (with filtering) into the target/classes folder.

The goal is that a subsequent maven build will not touch the jars at all.  In order to achieve that, the manifest is build in a separate directory and moved (with filtering) into the target/classes folder.
@gnodet gnodet marked this pull request as draft February 7, 2022 10:02
@gnodet
Copy link
Contributor Author

gnodet commented Feb 8, 2022

This should be update to maven-compiler-plugin 3.10.0 which should be released soon.

@cstamas
Copy link
Member

cstamas commented Apr 25, 2022

This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0?

1 similar comment
@cstamas
Copy link
Member

cstamas commented Apr 25, 2022

This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0?

@gnodet
Copy link
Contributor Author

gnodet commented Apr 25, 2022

This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0?

The upgrade to 6.2.0 was done 2 days ago, while my upgrade to 6.1.0 was 2 months ago.
Anyway, I have some pending changes for this PR, but this will depend on apache/maven-plugin-tools#67 and codehaus-plexus/plexus-utils#184. I'll have another look at this last PR to investigate the failing test.

@gnodet
Copy link
Contributor Author

gnodet commented Apr 25, 2022

This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0?

The upgrade to 6.2.0 was done 2 days ago, while my upgrade to 6.1.0 was 2 months ago. Anyway, I have some pending changes for this PR, but this will depend on apache/maven-plugin-tools#67 and codehaus-plexus/plexus-utils#184. I'll have another look at this last PR to investigate the failing test.

So @cstamas feel free to review codehaus-plexus/plexus-utils#184 which I've just fixed !

@gnodet gnodet closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants