-
Notifications
You must be signed in to change notification settings - Fork 145
Fixed #1426 : Replace archived org.semver:api with custom SemVer implementation
#1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harsh Mehta <[email protected]>
… into 1410 # Conflicts: # maven-release-policies/maven-release-semver-policy/pom.xml # maven-release-policies/maven-release-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver/SemVerVersionPolicy.java
…rsion policies and update related methods Signed-off-by: Harsh Mehta <[email protected]>
elharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. This is going to need some thought and discussion. If we can reduce the visibility to package protected that would enable us to release and iterate.
...src/main/java/org/apache/maven/shared/release/policy/semver/AbstarctSemVerVersionPolicy.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/apache/maven/shared/release/policy/semver/AbstractSemVerVersionPolicy.java
Show resolved
Hide resolved
...elease-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver/SemVer.java
Outdated
Show resolved
Hide resolved
...elease-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver/SemVer.java
Outdated
Show resolved
Hide resolved
...elease-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver/SemVer.java
Outdated
Show resolved
Hide resolved
...-policy/src/main/java/org/apache/maven/shared/release/policy/semver/SemVerVersionPolicy.java
Show resolved
Hide resolved
...se-semver-policy/src/test/java/org/apache/maven/shared/release/policy/semver/SemVerTest.java
Outdated
Show resolved
Hide resolved
...elease-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver/SemVer.java
Show resolved
Hide resolved
elharo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Run 'mvn spotless:apply' to fix these violations.
Signed-off-by: Harsh Mehta <[email protected]>
Signed-off-by: Harsh Mehta <[email protected]>
|
@elharo @slawekjaranowski However, @elharo pointed out that Maven only compatible with SemVer 1.0.0. Since I am still new to open-source contribution, I am trying to fully understand the intended direction. Could you please advise on the preferred approach so I can proceed accordingly? Thank you! |
...src/main/java/org/apache/maven/shared/release/policy/semver/AbstarctSemVerVersionPolicy.java
Outdated
Show resolved
Hide resolved
...se-semver-policy/src/test/java/org/apache/maven/shared/release/policy/semver/SemVerTest.java
Outdated
Show resolved
Hide resolved
...elease-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver/SemVer.java
Outdated
Show resolved
Hide resolved
…arsing tests Signed-off-by: Harsh Mehta <[email protected]>
org.semver:api with custom SemVer implementationorg.semver:api with custom SemVer implementation
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
mvn -Prun-its verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
I've gone ahead and applied for the Individual Contributor License Agreement.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
Replace archived
org.semver:apiwith customSemVerimplementationFixes #1426
What changed
org.semver:apilibrary.Version→SemVer, and refactored related version-policy code undermaven-release-semver-policy.SemVerclass.