Skip to content

Conversation

timpeeters
Copy link
Contributor

Fixes tests that broke while updating PMD from version 7.16.0 to version 7.17.0.

  • UselessOperationOnImmutable was replaced with UselessPureMethodCall
  • Update test fixtures because UnusedFormalParameter now ignores public constructors

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

dependabot bot and others added 3 commits September 12, 2025 11:03
Bumps `pmdVersion` from 7.16.0 to 7.17.0.

Updates `net.sourceforge.pmd:pmd-core` from 7.16.0 to 7.17.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/main/docs/render_release_notes.rb)
- [Commits](pmd/pmd@pmd_releases/7.16.0...pmd_releases/7.17.0)

Updates `net.sourceforge.pmd:pmd-java` from 7.16.0 to 7.17.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/main/docs/render_release_notes.rb)
- [Commits](pmd/pmd@pmd_releases/7.16.0...pmd_releases/7.17.0)

Updates `net.sourceforge.pmd:pmd-javascript` from 7.16.0 to 7.17.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/main/docs/render_release_notes.rb)
- [Commits](pmd/pmd@pmd_releases/7.16.0...pmd_releases/7.17.0)

Updates `net.sourceforge.pmd:pmd-jsp` from 7.16.0 to 7.17.0
- [Release notes](https://github.com/pmd/pmd/releases)
- [Changelog](https://github.com/pmd/pmd/blob/main/docs/render_release_notes.rb)
- [Commits](pmd/pmd@pmd_releases/7.16.0...pmd_releases/7.17.0)

---
updated-dependencies:
- dependency-name: net.sourceforge.pmd:pmd-core
  dependency-version: 7.17.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: net.sourceforge.pmd:pmd-java
  dependency-version: 7.17.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: net.sourceforge.pmd:pmd-javascript
  dependency-version: 7.17.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: net.sourceforge.pmd:pmd-jsp
  dependency-version: 7.17.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@slawekjaranowski
Copy link
Member

Please also update to pmd 7.17.0 .. we will see

@timpeeters timpeeters changed the base branch from dependabot/maven/pmdVersion-7.17.0 to master October 2, 2025 20:17
@timpeeters
Copy link
Contributor Author

Done.
I also had to bump invoker plugin to get it to run on Java 25.

@slawekjaranowski slawekjaranowski merged commit 3ef805b into apache:master Oct 6, 2025
26 checks passed
@github-actions github-actions bot added this to the 3.27.1 milestone Oct 6, 2025
Copy link

github-actions bot commented Oct 6, 2025

@slawekjaranowski Please assign appropriate label to PR according to the type of change.

@slawekjaranowski slawekjaranowski changed the title Fix #657 broken tests after upgrade to PMD 7.17.0 Bump pmdVersion from 7.16.0 to 7.17.0 Oct 6, 2025
@slawekjaranowski slawekjaranowski added dependencies Pull requests that update a dependency file enhancement New feature or request labels Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants