Skip to content

Conversation

olamy
Copy link
Member

@olamy olamy commented May 30, 2025

Signed-off-by: Olivier Lamy [email protected]

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy olamy marked this pull request as ready for review May 30, 2025 11:59
@olamy olamy merged commit d3fbbda into master May 30, 2025
131 checks passed
@olamy olamy deleted the cleanup-old-jdk-version-code branch May 30, 2025 23:21
@github-actions github-actions bot added this to the 3.11.3 milestone May 30, 2025
@olamy olamy linked an issue May 30, 2025 that may be closed by this pull request
Comment on lines +4337 to 4339
if (getLog().isWarnEnabled()) {
getLog().warn("Javadoc 1.4+ doesn't support the -1.1 switch anymore. Ignore this option.");
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @olamy

I was trying to track down where I have any of these options in my build as I started to see these warnigns in the logs 🙈 🙂

It seems that with this change the message is logged all the time, no matter if any option is set or not ..

maybe it should've been:

Suggested change
if (getLog().isWarnEnabled()) {
getLog().warn("Javadoc 1.4+ doesn't support the -1.1 switch anymore. Ignore this option.");
}
if (old && getLog().isWarnEnabled()) {
getLog().warn("Javadoc 1.4+ doesn't support the -1.1 switch anymore. Ignore this option.");
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure see there #1240

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 🙂 thanks for pointing me to that PR 🎉!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup of code related to old non supported Java version

2 participants