Skip to content

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Nov 19, 2024

No description provided.

@elharo elharo changed the title [MDEP-966] Migrate TreeMojo from Plexus to Sisu Guice [MDEP-966] Migrate TreeMojo/CopyMojo/AnalyzeExclusionsMojo from Plexus to Sisu Guice Nov 19, 2024
@elharo elharo changed the title [MDEP-966] Migrate TreeMojo/CopyMojo/AnalyzeExclusionsMojo from Plexus to Sisu Guice [MDEP-966] Migrate TreeMojo/CopyMojo/AnalyzeExclusionsMojo/UnpackMojo from Plexus to Sisu Guice Nov 19, 2024
@elharo elharo changed the title [MDEP-966] Migrate TreeMojo/CopyMojo/AnalyzeExclusionsMojo/UnpackMojo from Plexus to Sisu Guice [MDEP-966] Migrate TreeMojo/CopyMojo/AnalyzeExclusionsMojo/UnpackMojo/CopyDependenciesMojo from Plexus to Sisu Guice Nov 19, 2024
gnodet
gnodet previously requested changes Nov 19, 2024
public class AnalyzeExclusionsMojo extends AbstractMojo {

@Component
private MavenProject project;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constructor injected fields should be made final.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, done

@elharo elharo dismissed gnodet’s stale review November 28, 2024 13:52

comment addressed and done

@elharo elharo merged commit 969ed96 into master Nov 28, 2024
23 checks passed
@elharo elharo deleted the sisu branch November 28, 2024 15:42
@jira-importer
Copy link

Resolve #1480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants