Fixing flaky test in TestCopyDependenciesMojo #455
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses test flakiness in the following test:
org.apache.maven.plugins.dependency.fromDependencies.TestCopyDependenciesMojo#testGetDependencies
Problem
The test performs a
String
equality check on the content of dependencies stored inmojo.resolvedDependencies
against dependencies resolved throughmojo.getDependencySets(true).getResolvedDependencies()
.Since these dependencies are stored in
java.util.Set
collections, their ordering is non-deterministic, which occasionally causes test failures when executed with the Nondex plugin.Solution
To address this, I modified the test to verify that the sets contain the same elements, regardless of order.
I've changed the assertion from:
to
This ensures the test passes as long as both sets contain the same dependencies, regardless of order.
I'd appreciate any feedback on this approach and am open to making further adjustments if necessary.