Skip to content

Conversation

stokito
Copy link

@stokito stokito commented Oct 5, 2024

The outputTimestamp is checked to be not shorter than one char or to be a digit. The parsing of the outputTimestamp in the maven-jar-plugin is more complicated. But it's not needed to be done in the compiler plugin at all so it would be safer to remove it. We already had an IndexOutOfBoundsException when the string is empty because of the useless validation.

This is a simplification of the #244

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@michael-o michael-o requested a review from hboutemy October 6, 2024 10:05
@stokito stokito marked this pull request as draft October 9, 2024 07:02
Use the isNotEmpty() and add a comment about one char.

Signed-off-by: Sergey Ponomarev <[email protected]>
@stokito stokito marked this pull request as ready for review October 12, 2024 03:48
@stokito stokito closed this by deleting the head repository Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant