[MCHECKSTYLE-454] Running checkstyle:check when the project is on a path with accents fails

[jira-importer]

Emmanuel Lécharny opened MCHECKSTYLE-454 and commented

PS: also tested with 3.6.0 which has been released, but you haven't marked it as released in JIRA...

If the project I want to check is under a directory where a part of the path contain accents, like:

/user/elecharny/téléchargement/apache-sshd-2.15.9

then the checkstyle configuration file(in my case, sshd-checkstyle.xml) is either not found, or ignored.

If I rename téléchargement to download, all is fine.

---

Affects: 3.4.0, 3.5.0, 3.6.0

[jira-importer]

Michael Osipov commented

I cannot reproduce it:

osipovmi@deblndw011x:/tmp/апачэ (master =)
$ mvn checkstyle:check -V
Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: /tmp/apache-maven-3.9.9
Java version: 1.8.0_432, vendor: OpenJDK BSD Porting Team, runtime: /usr/local/openjdk8/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "freebsd", version: "13.4-stable", arch: "amd64", family: "unix"
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache Mina SSHD                                                   [pom]
[INFO] Apache Mina SSHD :: Common support utilities                       [jar]
[INFO] Apache Mina SSHD :: Core                                           [jar]
[INFO] Apache Mina SSHD :: Mina                                           [jar]
[INFO] Apache Mina SSHD :: Netty                                          [jar]
[INFO] Apache Mina SSHD :: SFTP                                           [jar]
[INFO] Apache Mina SSHD :: Benchmarks                                     [jar]
[INFO] Apache Mina SSHD :: Putty key files support utilities              [jar]
[INFO] Apache Mina SSHD :: OpenPGP key files support utilities            [jar]
[INFO] Apache Mina SSHD :: SCP                                            [jar]
[INFO] Apache Mina SSHD :: LDAP                                           [jar]
[INFO] Apache Mina SSHD :: Git                                            [jar]
[INFO] Apache Mina SSHD :: Contributions                                  [jar]
[INFO] Apache Mina SSHD :: Spring integration SFTP adapter                [jar]
[INFO] Apache Mina SSHD :: CLI                                            [jar]
[INFO] Apache Mina SSHD :: OSGi                                           [jar]
[INFO] Apache Mina SSHD :: Assembly                                       [pom]
[INFO]
[INFO] ------------------------< org.apache.sshd:sshd >------------------------
[INFO] Building Apache Mina SSHD 2.15.1-SNAPSHOT                         [1/17]
[INFO]   from pom.xml
[INFO] --------------------------------[ pom ]---------------------------------
[INFO]
[INFO] --- checkstyle:3.4.0:check (default-cli) @ sshd ---
[INFO] You have 0 Checkstyle violations.
[INFO]
[INFO] --------------------< org.apache.sshd:sshd-common >---------------------
[INFO] Building Apache Mina SSHD :: Common support utilities 2.15.1-SNAPSHOT [2/17]
[INFO]   from sshd-common/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- checkstyle:3.4.0:check (default-cli) @ sshd-common ---
[INFO] There are 57 errors reported by Checkstyle 9.3 with /tmp/апачэ/sshd-checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/sshd/common/config/keys/loader/openssh/kdf/BCrypt.java:[2] (header) Header: Zeile entspricht nicht der erwarteten Kopfzeile ' * Licensed to the Apache Software Foundation (ASF) under one'.
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/HostConfigEntryTest.java:[48,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/HostConfigEntryTest.java:[48,1] (sizes) MethodCount: Klasse hat 21 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/KnownHostEntryTest.java:[33,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/KnownHostHashEntryTest.java:[43,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/KnownHostHashValueTest.java:[42,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/NamedFactoryTest.java:[28,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/PropertyResolverParseBooleanTest.java:[38,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/PropertyTest.java:[44,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/channel/PtyModeValueTest.java:[42,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/channel/SttySupportTest.java:[40,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/cipher/BaseCipherResetTest.java:[45,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/cipher/ECCurvesTest.java:[38,1] (sizes) MethodCount: Klasse hat 6 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/compression/BuiltinCompressionsTest.java:[53,1] (sizes) MethodCount: Klasse hat 7 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/config/keys/AuthorizedKeyEntryLoginOptionsParseTest.java:[40,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/BuiltinIdentitiesTest.java:[51,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/EcdsaPublicKeyEntryDecoderTest.java:[42,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyRandomArtTest.java:[46,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyUtilsCloneTest.java:[49,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyUtilsFingerprintCaseSensitivityTest.java:[43,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyUtilsFingerprintGenerationTest.java:[48,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyUtilsTest.java:[65,1] (sizes) MethodCount: Klasse hat 9 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/AESPrivateKeyObfuscatorTest.java:[48,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHKeyPairResourceParserAEADTest.java:[40,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHKeyPairResourceParserDecodingTest.java:[44,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHKeyPairResourceParserPasswordTest.java:[53,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHMaxBCryptRoundsSettingTest.java:[44,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/pem/PKCS8PEMResourceKeyPairParserTest.java:[57,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/ssh2/Ssh2PublicKeyEntryDecoderByKeyTypeTest.java:[48,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/writer/openssh/OpenSSHKeyPairResourceWriterTest.java:[64,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/file/root/RootedFileSystemProviderTest.java:[73,1] (sizes) MethodCount: Klasse hat 40 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/kex/KexProposalOptionTest.java:[43,1] (sizes) MethodCount: Klasse hat 6 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/keyprovider/KeyIdentityProviderResolutionTest.java:[40,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/mac/BuiltinMacsTest.java:[51,1] (sizes) MethodCount: Klasse hat 7 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/mac/MacVectorsTest.java:[49,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/random/RandomFactoryTest.java:[37,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/signature/BuiltinSignaturesTest.java:[46,1] (sizes) MethodCount: Klasse hat 6 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/signature/RSASignatureVariantsTest.java:[37,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/ExceptionUtilsAndroidPeelTest.java:[40,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/GenericUtilsTest.java:[44,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/GenericUtilsTest.java:[44,1] (sizes) MethodCount: Klasse hat 11 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/util/Int2IntFunctionTest.java:[39,1] (sizes) MethodCount: Klasse hat 11 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/util/OsUtilsTest.java:[36,1] (sizes) MethodCount: Klasse hat 6 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/util/PathsConcatentionTest.java:[37,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/buffer/BufferTest.java:[36,1] (sizes) MethodCount: Klasse hat 8 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/util/io/ModifiableFileWatcherTest.java:[55,1] (sizes) MethodCount: Klasse hat 7 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/util/io/der/ASN1ClassTest.java:[35,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/io/der/ASN1TypeTest.java:[35,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/io/input/NullInputStreamTest.java:[39,1] (sizes) MethodCount: Klasse hat 6 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[ERROR] src/test/java/org/apache/sshd/common/util/io/output/LineOutputStreamTest.java:[44,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/net/SshdSocketIpv6AddressTest.java:[37,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/security/SecurityProviderRegistrarCipherNameTest.java:[40,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/security/SecurityUtilsDHGEXGroupKeySizeTest.java:[39,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/security/bouncycastle/BouncyCastleGeneratorHostKeyProviderTest.java:[53,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/common/util/security/eddsa/Ed25519VectorsTest.java:[53,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/server/keyprovider/SimpleGeneratorHostKeyProviderTest.java:[50,1] (coding) MissingCtor: Die Klasse sollte einen Konstruktor definieren.
[ERROR] src/test/java/org/apache/sshd/server/keyprovider/SimpleGeneratorHostKeyProviderTest.java:[50,1] (sizes) MethodCount: Klasse hat 6 Methoden mit Sichtbarkeit 'package' (Obergrenze ist 5).
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Mina SSHD 2.15.1-SNAPSHOT:
[INFO]
[INFO] Apache Mina SSHD ................................... SUCCESS [  2.361 s]
[INFO] Apache Mina SSHD :: Common support utilities ....... FAILURE [  5.031 s]
[INFO] Apache Mina SSHD :: Core ........................... SKIPPED
[INFO] Apache Mina SSHD :: Mina ........................... SKIPPED
[INFO] Apache Mina SSHD :: Netty .......................... SKIPPED
[INFO] Apache Mina SSHD :: SFTP ........................... SKIPPED
[INFO] Apache Mina SSHD :: Benchmarks ..................... SKIPPED
[INFO] Apache Mina SSHD :: Putty key files support utilities SKIPPED
[INFO] Apache Mina SSHD :: OpenPGP key files support utilities SKIPPED
[INFO] Apache Mina SSHD :: SCP ............................ SKIPPED
[INFO] Apache Mina SSHD :: LDAP ........................... SKIPPED
[INFO] Apache Mina SSHD :: Git ............................ SKIPPED
[INFO] Apache Mina SSHD :: Contributions .................. SKIPPED
[INFO] Apache Mina SSHD :: Spring integration SFTP adapter  SKIPPED
[INFO] Apache Mina SSHD :: CLI ............................ SKIPPED
[INFO] Apache Mina SSHD :: OSGi ........................... SKIPPED
[INFO] Apache Mina SSHD :: Assembly ....................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  10.302 s
[INFO] Finished at: 2025-02-18T09:28:52+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.4.0:check (default-cli) on project sshd-common: You have 57 Checkstyle violations. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :sshd-common

Path contains non-ASCII chars. Please provide your output.

[jira-importer]

Emmanuel Lécharny commented

Here you are:

elecharny@elecharny-XPS-13-9340:~/Téléchargements/apache-sshd-2.15.0/sshd-common$  mvn checkstyle:check -V
Apache Maven 3.9.9 (8e8579a9e76f7d015ee5ec7bfcdc97d260186937)
Maven home: /opt/maven
Java version: 17.0.14, vendor: Ubuntu, runtime: /usr/lib/jvm/java-17-openjdk-amd64
Default locale: fr_FR, platform encoding: UTF-8
OS name: "linux", version: "6.11.0-17-generic", arch: "amd64", family: "unix"
[INFO] Scanning for projects...
[INFO] 
[INFO] --------------------< org.apache.sshd:sshd-common >---------------------
[INFO] Building Apache Mina SSHD :: Common support utilities 2.15.0
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- checkstyle:3.4.0:check (default-cli) @ sshd-common ---
[INFO] There are 57 errors reported by Checkstyle 9.3 with /home/elecharny/Téléchargements/apache-sshd-2.15.0/sshd-checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/sshd/common/config/keys/loader/openssh/kdf/BCrypt.java:[2] (header) Header: La ligne ne correspond pas à la ligne d'en-tête attendue ' * Licensed to the Apache Software Foundation (ASF) under one'.
[ERROR] src/test/java/org/apache/sshd/common/channel/PtyModeValueTest.java:[42,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/channel/SttySupportTest.java:[40,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/signature/RSASignatureVariantsTest.java:[37,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/signature/BuiltinSignaturesTest.java:[46,1] (sizes) MethodCount: Le nombre de méthodes de package est de 6 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/file/root/RootedFileSystemProviderTest.java:[73,1] (sizes) MethodCount: Le nombre de méthodes de package est de 40 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/random/RandomFactoryTest.java:[37,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/PropertyTest.java:[44,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/Int2IntFunctionTest.java:[39,1] (sizes) MethodCount: Le nombre de méthodes de package est de 11 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/util/security/SecurityUtilsDHGEXGroupKeySizeTest.java:[39,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/security/SecurityProviderRegistrarCipherNameTest.java:[40,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/security/bouncycastle/BouncyCastleGeneratorHostKeyProviderTest.java:[53,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/security/eddsa/Ed25519VectorsTest.java:[53,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/OsUtilsTest.java:[36,1] (sizes) MethodCount: Le nombre de méthodes de package est de 6 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/util/PathsConcatentionTest.java:[37,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/GenericUtilsTest.java:[44,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/GenericUtilsTest.java:[44,1] (sizes) MethodCount: Le nombre de méthodes de package est de 11 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/util/io/der/ASN1ClassTest.java:[35,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/io/der/ASN1TypeTest.java:[35,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/io/output/LineOutputStreamTest.java:[44,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/io/ModifiableFileWatcherTest.java:[55,1] (sizes) MethodCount: Le nombre de méthodes de package est de 7 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/util/io/input/NullInputStreamTest.java:[39,1] (sizes) MethodCount: Le nombre de méthodes de package est de 6 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/util/buffer/BufferTest.java:[36,1] (sizes) MethodCount: Le nombre de méthodes de package est de 8 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/util/ExceptionUtilsAndroidPeelTest.java:[40,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/util/net/SshdSocketIpv6AddressTest.java:[37,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/PropertyResolverParseBooleanTest.java:[38,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/NamedFactoryTest.java:[28,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/kex/KexProposalOptionTest.java:[43,1] (sizes) MethodCount: Le nombre de méthodes de package est de 6 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/compression/BuiltinCompressionsTest.java:[53,1] (sizes) MethodCount: Le nombre de méthodes de package est de 7 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/cipher/ECCurvesTest.java:[38,1] (sizes) MethodCount: Le nombre de méthodes de package est de 6 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/cipher/BaseCipherResetTest.java:[45,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyUtilsFingerprintCaseSensitivityTest.java:[43,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/BuiltinIdentitiesTest.java:[51,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyUtilsTest.java:[65,1] (sizes) MethodCount: Le nombre de méthodes de package est de 9 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHKeyPairResourceParserDecodingTest.java:[44,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHMaxBCryptRoundsSettingTest.java:[44,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHKeyPairResourceParserPasswordTest.java:[53,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/openssh/OpenSSHKeyPairResourceParserAEADTest.java:[40,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/ssh2/Ssh2PublicKeyEntryDecoderByKeyTypeTest.java:[48,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/pem/PKCS8PEMResourceKeyPairParserTest.java:[57,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/loader/AESPrivateKeyObfuscatorTest.java:[48,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/EcdsaPublicKeyEntryDecoderTest.java:[42,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/writer/openssh/OpenSSHKeyPairResourceWriterTest.java:[64,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/AuthorizedKeyEntryLoginOptionsParseTest.java:[40,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyUtilsCloneTest.java:[49,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyUtilsFingerprintGenerationTest.java:[48,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/config/keys/KeyRandomArtTest.java:[46,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/keyprovider/KeyIdentityProviderResolutionTest.java:[40,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/common/mac/BuiltinMacsTest.java:[51,1] (sizes) MethodCount: Le nombre de méthodes de package est de 7 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/common/mac/MacVectorsTest.java:[49,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/KnownHostEntryTest.java:[33,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/HostConfigEntryTest.java:[48,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/HostConfigEntryTest.java:[48,1] (sizes) MethodCount: Le nombre de méthodes de package est de 21 alors que le maximum autorisé est de 5.
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/KnownHostHashEntryTest.java:[43,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/client/config/hosts/KnownHostHashValueTest.java:[42,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/server/keyprovider/SimpleGeneratorHostKeyProviderTest.java:[50,1] (coding) MissingCtor: Il manque un constructeur à la classe.
[ERROR] src/test/java/org/apache/sshd/server/keyprovider/SimpleGeneratorHostKeyProviderTest.java:[50,1] (sizes) MethodCount: Le nombre de méthodes de package est de 6 alors que le maximum autorisé est de 5.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.976 s
[INFO] Finished at: 2025-02-18T09:44:50+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.4.0:check (default-cli) on project sshd-common: You have 57 Checkstyle violations. -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

For clarity, I went into the sshd-common module, but you get the same output from the project's root

[jira-importer]

Emmanuel Lécharny commented

Just in case, here are my locale:

$ locale
LANG=fr_FR.UTF-8
LANGUAGE=
LC_CTYPE="fr_FR.UTF-8"
LC_NUMERIC="fr_FR.UTF-8"
LC_TIME="fr_FR.UTF-8"
LC_COLLATE="fr_FR.UTF-8"
LC_MONETARY="fr_FR.UTF-8"
LC_MESSAGES="fr_FR.UTF-8"
LC_PAPER="fr_FR.UTF-8"
LC_NAME="fr_FR.UTF-8"
LC_ADDRESS="fr_FR.UTF-8"
LC_TELEPHONE="fr_FR.UTF-8"
LC_MEASUREMENT="fr_FR.UTF-8"
LC_IDENTIFICATION="fr_FR.UTF-8"
LC_ALL=

[jira-importer]

Michael Osipov commented

I ran a few tests, the ticket needs more explanation:
If the plugin is being run on a non-ASCII path the execution fails, but if the path is ASCII only it succeeds. I ran checkstyle manually and it does not fail in any case. There is obviously a bug in the plugin. Now it is clear, thanks for the report. Although I do not see the issue from the top of my head. I need to dig in here.

[jira-importer]

Emmanuel Lécharny commented

What puzzles me is that when you try it with cyrillic chars, it works, but if I create the same path, it wails for me. This is why I pasted my locale, because I think it may have an impact on the way the resources are pulled.

OTOH, it may well be an issue with checkstyle itself... That would worth a try: running checkstyle on the command line to see if it's the case.

[jira-importer]

Emmanuel Lécharny commented

Tested on the command line with checkstyle alone, it seems to be happy, AFAICT. So back to square one, a bug in the maven plugin.

~/Téléchargements/raté$ java -jar checkstyle-10.21.2-all.jar -c /home/elecharny/Téléchargements/raté/sshd-checkstyle.xml sshd-common/src/test/java/org/apache/sshd/server/keyprovider/PEMGeneratorHostKeyProviderTest.java  -d
févr. 18, 2025 11:18:56 AM com.puppycrawl.tools.checkstyle.Main runCli
PRÉCIS: Checkstyle debug logging enabled
févr. 18, 2025 11:18:56 AM com.puppycrawl.tools.checkstyle.Main runCli
PRÉCIS: Running Checkstyle with version: 10.21.2
Début de la vérification...
Vérification terminée.

Note that I had to tweek the checkstyle configuration file to get rid of ${} variables.

[jira-importer]

Michael Osipov commented

To be clear, it fails with Maven with non-ASCII chars. Whether it is accent or Russian, does not matter. As long it is not 7-bit you are busted. The Checkstyle JAR always works for me.

[jira-importer]

Michael Osipov commented

My execution: JAVA_VERSION=11 java -jar checkstyle-10.21.2-all.jar -c sshd-common/target/checkstyle-checker.xml sshd-common/src/test

[jira-importer]

Michael Osipov commented

I need to apply this:

$ git diff
diff --git a/src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java b/src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
index bd30668..1565009 100644
--- a/src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
+++ b/src/main/java/org/apache/maven/plugins/checkstyle/exec/DefaultCheckstyleExecutor.java
@@ -109,6 +109,8 @@ public class DefaultCheckstyleExecutor implements CheckstyleExecutor {
         FilterSet filterSet = getSuppressionsFilterSet(suppressionsFilePath);

         Checker checker = new Checker();
+        checker.setLocaleLanguage("");
+        checker.setLocaleCountry("");

         // setup classloader, needed to avoid "Unable to get class information for ..." errors
         List<String> classPathStrings = new ArrayList<>();

like I did in MJAVADOC-803.