Asynchronous Sending for RemoteSyslogAppender in log4net #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yogitasingh001 thanks for your proposal. |
|
@FreeAndNil thanks |
|
implements #255 |
FreeAndNil
changed the base branch from
master
to
Feature/ImprovementRemoteSyslogApp
FreeAndNil
approved these changes
Jun 11, 2025
There was a problem hiding this comment.
I will merge your PR into https://github.com/apache/logging-log4net/tree/Feature/ImprovementRemoteSyslogApp and work in this branch.
Thanks for your proposal and solution.
FreeAndNil
merged commit ed3ed52
into
apache:Feature/ImprovementRemoteSyslogApp
3 checks passed
FreeAndNil
pushed a commit
that referenced
this pull request
Jun 16, 2025
Co-authored-by: yogita singh <[email protected]>
FreeAndNil
pushed a commit
that referenced
this pull request
Jun 19, 2025
Co-authored-by: yogita singh <[email protected]>
|
Ok @FreeAndNil i will test and update. Sorry for the late response |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a major performance bottleneck in RemoteSyslogAppender, where synchronous .Wait() calls were blocking high-throughput applications.
Summary of Changes
Introduced a background task and queue (producer-consumer model) for async UDP sends
Removed thread-blocking .Wait() from Append() method
Ensured graceful shutdown with cancellation tokens
Documentation included at docs/AsynchronousSendingforRemoteSyslogAppenderinlog4net.pdf
Request
Please consider reviewing and including this change in a future release. We rely on log4net and would prefer not to maintain a separate fork.