MINOR: Add Unit test for TimingWheel
#20443
Merged
+228
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1a2st
changed the title
TimingWheel
m1a2st
changed the title
TimingWheelTimingWheel
chia7712
reviewed
Sep 3, 2025
| private final long tickMs = 10L; | ||
| private final int wheelSize = 5; | ||
|
|
||
| @BeforeEach |
There was a problem hiding this comment.
those variables could be initialized in constructor, right?
private final long startMs = 1000L;
private final long tickMs = 10L;
private final int wheelSize = 5;
private final DelayQueue<TimerTaskList> queue = new DelayQueue<>();
private final AtomicInteger taskCounter = new AtomicInteger(0);
private final TimingWheel timingWheel = new TimingWheel(tickMs, wheelSize, startMs, taskCounter, queue);There was a problem hiding this comment.
In the separate test we will use these variables. If we initialize them in the constructor, we would need to add a test-only method for each variable, correct?
There was a problem hiding this comment.
The default Junit 5 lifecycle is PER_METHOD, meaning each test case has its own test instance. That is why I suggest initializing those variables in the consutrcotr
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is any unit test for
TimingWheel, we should add test for it.Reviewers: Chia-Ping Tsai [email protected]